[MPlayer-cvslog] r20499 - trunk/mplayer.c

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Wed Nov 1 13:38:12 CET 2006


Hello,
On Wed, Nov 01, 2006 at 01:11:32PM +0100, Attila Kinali wrote:
> On Sun, 29 Oct 2006 04:23:23 +0100 (CET)
> eugeni <subversion at mplayerhq.hu> wrote:
> 
> > -if(1 || ass_enabled) {  // even if ass_enabled==0 now it can be used
> > +{
> 
> Please don't leave curly braces in the code.
> If an "if" statement disapeares, just remove it.
> Later fix the indentation with a second commit.
> 
> Otherwise we clutter the code with hundreds of
> blocks that make no sense.

They make sense because this block has its own local variables.

Greetings,
Reimar Döffinger



More information about the MPlayer-cvslog mailing list