[MPlayer-cvslog] r21265 - in trunk: configure loader/config.h

[Diego Biurrun]

On Sun, Nov 26, 2006 at 02:17:50PM +0100, uau wrote:
> 
> Added:
>    trunk/loader/config.h
>       - copied unchanged from r21250, /trunk/loader/config.h
> Modified:
>    trunk/configure
> 
> Log:
> Revert r21251 (moving loader/config.h contents to main config.h).

Please don't just revert commits from other devs (in code not maintained
by you) without discussion.  Yes, we got a report that this broke
compilation, but only one one system, not in the general case.  If I was
unavailable or not reacting (quickly) to bug reports, it would be a
different thing.  The issue is not so urgent that it cannot wait a few
hours.

> There are #ifdef TRACE tests in libav* and defining TRACE in toplevel
> config.h breaks things.

I want to see loader/config.h gone.  IMO there should never be multiple
header files with the same name, period.

I see two possible solutions apart from renaming TRACE in loader/ or
libav*/:

- Move those definitions to the CFLAGS of loader/Makefile.
- Move those definitions to config.h and surround them by '#ifdef LOADER'
  or something similar that gets defined only during the compilation of
  loader/.

Diego