[MPlayer-cvslog] r21242 - trunk/bswap.h

[Reimar Döffinger]

Hello,
On Sun, Nov 26, 2006 at 11:40:28AM -0500, Nicolas Plourde wrote:
> On 26-Nov-06, at 8:21 AM, Reimar Döffinger wrote:
> >>
> >>This broke compilation on some bigendian systems, because in  
> >>libavutil
> >>bswap_32 is a function, not a macro.
> >>Attached patch just removes that (IMO) horrible initialization in
> >>ao_pcm.c.
> >
> >Applied, since there is no reason le2me_32 of a constant expression  
> >has
> >to be a constant expression, thus the old code was just wrong.
> >>
> 
> This broke build on intel osx.
> 
> cc -c -I. -I.. -Inative -I../libmpdemux -I../stream -I../loader -I../ 
> libavutil -I../libavcodec -Wdeclaration-after-statement -O4 - 
> march=pentium-m -mtune=pentium-m -pipe -ffast-math -fomit-frame- 
> pointer -mdynamic-no-pic -falign-loops=16 -DSYS_DARWIN - 
> DCONFIG_DARWIN -shared-libgcc -arch i386 -isysroot /Developer/SDKs/ 
> MacOSX10.4u.sdk -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 - 
> D_LARGEFILE64_SOURCE -I/usr/X11R6/include -I/usr/local/include/ 
> freetype2 -I/usr/local/include -D_GNU_SOURCE  -o ad_qtaudio.o  
> ad_qtaudio.c
> In file included from /Developer/SDKs/MacOSX10.4u.sdk/usr/include/ 
> math.h:28,
>                  from /Developer/SDKs/MacOSX10.4u.sdk/System/Library/ 
> Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:19,
>                  from /Developer/SDKs/MacOSX10.4u.sdk/System/Library/ 
> Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/ 
> Headers/CarbonCore.h:20,
>                  from /Developer/SDKs/MacOSX10.4u.sdk/System/Library/ 
> Frameworks/CoreServices.framework/Headers/CoreServices.h:21,
>                  from /Developer/SDKs/MacOSX10.4u.sdk/System/Library/ 
> Frameworks/Carbon.framework/Headers/Carbon.h:20,
>                  from /Developer/SDKs/MacOSX10.4u.sdk/System/Library/ 
> Frameworks/QuickTime.framework/Headers/QuickTimeComponents.h:20,
>                  from ad_qtaudio.c:19:
> /Developer/SDKs/MacOSX10.4u.sdk/usr/include/architecture/i386/math.h: 
> 167: error: parse error before '__attribute__'

Related to the always_inline define recently discussed on ffmpeg-dev.
Hopefully someone comes up with a good solution there.

Greetings,
Reimar Döffinger