[MPlayer-cvslog] r21242 - trunk/bswap.h

[Reimar Döffinger]

Hello,
On Tue, Nov 28, 2006 at 07:02:30PM +0100, Diego Biurrun wrote:
> On Tue, Nov 28, 2006 at 06:59:38PM +0100, Reimar Döffinger wrote:
> > On Tue, Nov 28, 2006 at 06:38:18PM +0100, Diego Biurrun wrote:
> > > BTW, what about merging all of our bswap.h into FFmpeg's?  Only
> > > bswap_dbl and bswap_ldbl are used in any case.  The license should be no
> > > problem, I'm sure Reimar will be willing to make it LGPL.
> > 
> > They are a hack and not really correct (esp. since fpu endianness can
> > differ from int endianness). The two places or so where they are used should
> > be fixed to use the float reading code from lavu.
> 
> Shouldn't be all that hard, they are only used in
> 
> libmpdemux/nuppelvideo.h (bswap_dbl)
> libmpdemux/ebml.c        (bswap_ldbl)
> 
> Any volunteers? :)

I'll look into it, though I remember there was some problem.
Also, libavutil/bswap.h still needs libavutil/common.h to be included
first, so it's not just a matter of removing our bswap.h

Greetings,
Reimar Döffinger