[MPlayer-cvslog] r20517 - in trunk/libass: ass.c ass_bitmap.c ass_render.c ass_utils.c ass_utils.h

[Reimar Döffinger]

Hello,
On Sun, Oct 29, 2006 at 04:03:30PM +0100, eugeni wrote:
> Author: eugeni
> Date: Sun Oct 29 16:03:30 2006
> New Revision: 20517
> 
> Modified:
>    trunk/libass/ass.c
>    trunk/libass/ass_bitmap.c
>    trunk/libass/ass_render.c
>    trunk/libass/ass_utils.c
>    trunk/libass/ass_utils.h
> 
> Log:
> Copy the following functions to libass to avoid dependency on the rest of mplayer:
> guess_buffer_cp
> utf8_get_char
> blur

Code duplication really is not acceptable in MPlayer. Why do you want to
avoid these dependencies? Can't you just add a separate file with these
functions wherever else you use libass? At least use some #ifdef hacks
to use wrappers for the MPlayer fuctions when compiling within MPlayer.

Greetings,
Reimar Döffinger