[MPlayer-cvslog] r19087 - in trunk: ChangeLog DOCS/man/en/mplayer.1 DOCS/xml/en/codecs.xml DOCS/xml/en/install.xml cfg-common.h cfg-mencoder.h cfg-mplayer.h codec-cfg.c configure divx4_vbr.c divx4_vbr.h etc/codecs.conf help/help_mp-en.h libmpcodecs/Makefile libmpcodecs/vd.c libmpcodecs/vd_divx4.c libmpcodecs/vd_odivx.c libmpcodecs/ve.c libmpcodecs/ve_divx4.c libmpdemux/video.c libvo/video_out.c mencoder.c

[Diego Biurrun]

On Tue, Sep 12, 2006 at 01:07:45AM +0300, Uoti Urpala wrote:
> On Mon, 2006-09-11 at 15:40 +0200, Diego Biurrun wrote:
> > On Mon, Sep 11, 2006 at 03:48:33PM +0300, Uoti Urpala wrote:
> > > On Mon, 2006-09-11 at 14:35 +0200, Diego Biurrun wrote:
> > > > Thankfully nobody noticed this one, else he would have made me drink
> > > > insane amounts of a certain softdrink ;-)
> > > 
> > > I actually did notice that a while ago when I was checking something
> > > else, but didn't point it out at the time.
> > 
> > Huh?  Why?  I'd gladly have been notified of this (admittedly
> > embarassing) oversight...
> 
> I don't remember exactly why, at least I didn't consider it too
> important as the code was questionable in either version.

OK.  Yes, the code lead to regressions, I had it backed out in my tree
for a reason.

Next time, please do speak up, if only with a quick note.  It's
important to notify people of their slipups.  This also led to a bit of
confusion.  Some time ago Roberto and I were wondering why the Theora
seeking regression had disappeared...

Diego