[MPlayer-cvslog] r19844 - trunk/stream/stream_dvdnav.c

Diego Biurrun diego at biurrun.de
Tue Sep 19 16:21:54 CEST 2006

On Mon, Sep 18, 2006 at 10:51:03PM +0200, Nico Sabbi wrote:
> Diego Biurrun wrote:
> >On Fri, Sep 15, 2006 at 07:42:14PM +0200, nicodvb wrote:
> >
> >>Modified:
> >>  trunk/stream/stream_dvdnav.c
> >>
> >>Log:
> >>removed code that propagated the slave command dvdnav_event that hasn't 
> >>been handled for years; patch by Jonas Jermann
> >
> >Does that mean that the command is disabled?  Why not remove it
> >completely then?
> I'm reluctant to remove code that, although not used now,
> may be needed in the future to enable all the functionalities
> that are not yet working

But right now we have a command documented that does not work..  This is
worse than not having it at all.  Don't just remove half of it and leave
the rest behind to rot.  You can resurrect it anytime from the
Subversion history *if* you should need it...


More information about the MPlayer-cvslog mailing list