[MPlayer-cvslog] r19959 - trunk/vidix/drivers/radeon_vid.c

The Wanderer inverseparadox at comcast.net
Sun Sep 24 14:36:06 CEST 2006

Rich Felker wrote:

> On Sat, Sep 23, 2006 at 06:46:08PM +0200, faust3 wrote:

>>  #endif
>> +  printf(RADEON_MSG" Video memory = %uMb\n",radeon_ram_size/0x100000);
>>  #ifdef WIN32
>> +  //mapping large areas of video ram will fail on windows
> Change this to fprintf to stderr or better yet a proper log callback.
> Having vidix drivers spam stdout is not acceptable.

Just for the record, this isn't the only such offense - there are
presently 210 occurrences of '\bprintf' in vidix/drivers/*.c, 32 of them
in that file.

That's out of ~1750 in the entirety of MPlayer, counting various
included libraries (other than libav*); some of those are probably
supposed to be there, but I've never been entirely clear on which files
are considered separate enough to be allowed to use stdout directly.

       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.

More information about the MPlayer-cvslog mailing list