[MPlayer-cvslog] r22920 - in trunk/vidix: drivers.c drivers.h vidix.h vidixlib.c vidixlib.h

[Diego Biurrun]

On Fri, Apr 06, 2007 at 09:43:04PM +0200, Benjamin Zores wrote:
> Diego Biurrun a écrit :
> >On Fri, Apr 06, 2007 at 05:30:39PM +0200, ben wrote:
> >>Modified:
> >>   trunk/vidix/drivers.c
> >>   trunk/vidix/drivers.h
> >>   trunk/vidix/vidix.h
> >>   trunk/vidix/vidixlib.c
> >>   trunk/vidix/vidixlib.h
> >>
> >>Log:
> >>missing headers in vidix drivers registry files
> >
> >I'm all in favor of this, but why not give all files consistent headers?
> 
> I've planned to do so some day around.

Well, why not do it now then?

> Currenlty VIDIX/libdha is messing up with headers and no one knows if it 
> is still GPL or LGPL by the way.

If it is LGPL, it is GPL as well.  Besides, IIRC Nick just slapped a new
license header on some files without asking the authors (all authors?)
for permission.

> >>--- trunk/vidix/drivers.c	(original)
> >>+++ trunk/vidix/drivers.c	Fri Apr  6 17:30:39 2007
> >>@@ -1,3 +1,22 @@
> >>+/*
> >>+ *  Copyright (C) 2007 Benjamin Zores <ben at geexbox.org>
> >>+ *   Vidix drivers registry handler.
> >
> >Vidix or VIDIX?
> 
> No idea.

I thought the official name was VIDIX.  We should at least be
consistent.

> >>+ *   This program is free software; you can redistribute it and/or modify
> >>+ *  it under the terms of the GNU General Public License as published by
> >>+ *  the Free Software Foundation; either version 2 of the License, or
> >>+ *  (at your option) any later version.
> >>+ *
> >>+ *   This program is distributed in the hope that it will be useful,
> >>+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> >>+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> >>+ *  GNU General Public License for more details.
> >>+ *
> >>+ *   You should have received a copy of the GNU General Public License
> >>+ *  along with this program; if not, write to the Free Software 
> >>Foundation,
> >>+ *  Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> >>+ */
> >
> >Where did you copy and paste this from?  I don't mind the funky
> >indentation (although I would prefer completely uniform headers), but
> >what is "this program" exactly?  This imprecise term should be replaced
> >by something more meaningful like "MPlayer" or "VIDIX".
> 
> stream/stream_pvr.[hc]

And where did you take this license header from? :)

I would suggest using one of the GPL license headers from FFmpeg as a
template and replace "this program" by something meaningful.  Either
"VIDIX" or "MPlayer" depending on whether you consider vidix/ separate
from MPlayer or not.

Diego