[MPlayer-cvslog] r22991 - in trunk: configure vidix/Makefile vidix/drivers.c

[Reimar Döffinger]

Hello,
On Sat, Apr 14, 2007 at 12:39:17PM +0200, ben wrote:
> Author: ben
> Date: Sat Apr 14 12:39:17 2007
> New Revision: 22991
> 
> Modified:
>    trunk/configure
>    trunk/vidix/Makefile
>    trunk/vidix/drivers.c
> 
> Log:
> added conditional vidix drivers compilation
> 
> Modified: trunk/configure

Unless you asked him privately, IIRC Diego is the build system maintainer and
you IMO should give him a chance to comment.

> Modified: trunk/vidix/Makefile
> ==============================================================================
> --- trunk/vidix/Makefile	(original)
> +++ trunk/vidix/Makefile	Sat Apr 14 12:39:17 2007
> @@ -3,15 +3,29 @@ include ../config.mak
>  LIBNAME_MPLAYER = libvidix.a
>  
>  SRCS_MPLAYER    = vidixlib.c \
> +		  drivers.c \
>  		  dha.c \
>  		  mtrr.c \
>  		  pci.c \
>  		  pci_names.c \
> -		  pci_dev_ids.c \
> -                  $(wildcard *.c)
> +		  pci_dev_ids.c
>  
> -OBJS_MPLAYER    = mga_crtc2_vid.o \
> -                  rage128_vid.o \
> +SRCS_MPLAYER-$(CONFIG_VIDIX_CYBERBLADE) 	+= cyberblade_vid.c
> +SRCS_MPLAYER-$(CONFIG_VIDIX_MACH64) 		+= mach64_vid.c
> +SRCS_MPLAYER-$(CONFIG_VIDIX_MGA) 		+= mga_vid.c
> +SRCS_MPLAYER-$(CONFIG_VIDIX_NVIDIA) 		+= nvidia_vid.c
> +SRCS_MPLAYER-$(CONFIG_VIDIX_PM3) 		+= pm3_vid.c
> +SRCS_MPLAYER-$(CONFIG_VIDIX_RADEON) 		+= radeon_vid.c
> +SRCS_MPLAYER-$(CONFIG_VIDIX_SAVAGE) 		+= savage_vid.c
> +SRCS_MPLAYER-$(CONFIG_VIDIX_SIS) 		+= sis_vid.c sis_bridge.c
> +SRCS_MPLAYER-$(CONFIG_VIDIX_UNICHROME) 		+= unichrome_vid.c

Not specific to this patch, since the Makefile is already like that, but
tabs seem like a really bad idea for aligning stuff to me, as this email
demonstrates (at least here "+= unichrome_vid.c" is clearly not aligned
with the rest)...

Greetings,
Reimar Döffinger