[MPlayer-cvslog] r23139 - in trunk: libmpcodecs/ae_lavc.c libmpcodecs/vf.c libmpdemux/demuxer.c libmpdemux/muxer.c

[Diego Biurrun]

On Thu, Apr 26, 2007 at 10:11:52PM +0200, Nico Sabbi wrote:
> Diego Biurrun wrote:
> 
> >>>Log:
> >>>Simplify preprocessor directives: There is a general variable for
> >>>static/shared FFmpeg libraries now.
> >>>
> >>why??? it's disgusting. It leads to the same mess that a unified 
> >>USE_LIBAVCODEC introduced;
> >>
> >>We had already talked about it in the past, and I believe that we
> >>agreed that eventually the opposite should have been made:
> >>distinguishing between USE_LIBAVCODEC and USE_LIBAVCODEC_SO
> >
> >I don't follow you here.  What exactly is the problem?  AFAICT I did
> >what you are suggesting ...
> 
> the opposite: if  there's only 1 variable for USE_LIBAVFORMAT
> you can't tell if you are using the imported or the external library

There is one variable for each of the three cases:

1) static
2) shared
3) either

Diego