[MPlayer-cvslog] r25338 - trunk/TOOLS/netstream.c

[Rich Felker]

On Mon, Dec 10, 2007 at 05:26:18PM +0100, Diego Biurrun wrote:
> On Mon, Dec 10, 2007 at 11:04:07AM -0500, Rich Felker wrote:
> > On Mon, Dec 10, 2007 at 02:18:28PM +0100, diego wrote:
> > > 
> > > Log:
> > > Remove unused parameters from main(), fixes the warnings:
> > > netstream.c:340: warning: unused parameter 'argc'
> > > netstream.c:340: warning: unused parameter 'argv'
> > 
> > Unused parameter is an idiotic warning for many reasons.
> 
> I'll be delighted to hear the reasons.

The parameter list is dictated by the interface of the function, not
by the implementation. It's very reasonable that a given
implementation need not use all the arguments passed to it. This is
especially true when implementing functions to be used as function
pointers conforming to a general-purpose interface.

> > Why do you have it enabled?
> 
> I just added "-Wall -W -Wextra" to TOOLS/Makefile to get warnings
> printed.

Trying to "correct" all the crap printed at this insane warning level
is totally misguided...

> > I'm against changes like this.
> 
> What's the problem?

It's senseless and would just need to be reverted if anyone ever
decided to use the command line arguments. It also decreases the
signal to noise ratio of the commit log just about as much as sending
enlargement pill emails to the list would do..

Rich