[MPlayer-cvslog] r25404 - trunk/stream/vcd_read_darwin.h

[Reimar Döffinger]

Hello,
On Sun, Dec 16, 2007 at 11:48:59AM -0500, Rich Felker wrote:
> On Sat, Dec 15, 2007 at 02:24:02PM +0100, Reimar Döffinger wrote:
> > > change the position of buf in that structure is the easiest way to fix
> > > this problem on my machine.
> > > As why the pread need it be aligned, I think only apple knows.
> > 
> > The problems, _if_ this really is the reason, it was a bug in OSX, not
> > in MPlayer.
> 
> Indeed, but non-aligned read is sure to be slower anyway I think so
> it's a good idea to put it at an aligned position. And someone should
> flame OSX because this seems like a genuine bug that might not be
> possible to work around in an arbitrary application.

Well, if we could replace that pread with normal read (no idea of read
with arbitrary offsets is supported for these block devices) we could
save a memcpy and possibly also read more than one sector per function
call...
Even if not there sure would be quite a few optimization
possibilities...

Greetings,
Reimar Döffinger