[MPlayer-cvslog] r25376 - trunk/mp3lib/sr1.c

[Diego Biurrun]

On Wed, Dec 12, 2007 at 01:35:05PM +0100, Reimar Döffinger wrote:
> On Wed, Dec 12, 2007 at 09:29:56AM +0100, diego wrote:
> > 
> > Log:
> > Add missing declaration for dct64_altivec, fixes the warning:
> > In file included from layer3.c:1171,
> >                  from sr1.c:391:
> > decod386.c: In function 'synth_1to1':
> > decod386.c:145: warning: implicit declaration of function 'dct64_altivec'
> > 
> > --- trunk/mp3lib/sr1.c	(original)
> > +++ trunk/mp3lib/sr1.c	Wed Dec 12 09:29:55 2007
> > @@ -386,6 +386,8 @@ retry1:
> >  
> >  static int _has_mmx = 0;  // used by layer2.c, layer3.c to pre-scale coeffs
> >  
> > +extern void dct64_altivec(real *, real *, real *);
> 
> I think the "rule" is not to use "extern" for function prototypes in new
> code, or does someone disagree?

No opinion about this from my side, I just stuck to the way the other
functions were declared in that file.

Diego