[MPlayer-cvslog] r21962 - trunk/libmpcodecs/ae_lavc.c

[Nico Sabbi]

Reimar Doeffinger wrote:

>Hello,
>On Fri, Jan 19, 2007 at 02:19:03AM +0100, nicodvb wrote:
>  
>
>>Author: nicodvb
>>Date: Fri Jan 19 02:19:02 2007
>>New Revision: 21962
>>
>>Modified:
>>   trunk/libmpcodecs/ae_lavc.c
>>
>>Log:
>>include the right riff.h according to USE_LIBAVFORMAT_SO|USE_LIBAVFORMAT; please stop breaking code that uses *_SO
>>    
>>
>
>1) you should fix it everywhere, not just in one place
>2) since riff.h does not get installed, it is your change that breaks it
>  
>
no, it doesn't break anything. Unconditionally including a file that may 
be missing
breaks compilation

>3) #include "libavformat/riff.h" should work just fine with the SO
>stuff, even if it is ugly, unless you mix MPlayer with versions of
>ffmpeg that are incompatible and I absolutely _refuse_ to support that.
>  
>
when the user doesn't have libavformat/ in main but libavformat installed
globally (as in my case) how can libavformat/riff.h be included?

At first I didn't remember that long time ago I patched my copy of ffmpeg
to install riff.h but forgot to post it, so I assumed that the file was 
already
supposed to be available. sorry for the confusion

 
 
 --
 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 
 Sponsor:
 Scopri la tradizione del buon vino, offerta di benvenuto con regalo
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=3926&d=19-1