[MPlayer-cvslog] r23703 - in trunk/gui: app.h mplayer/gmplayer.h mplayer/gtk/mb.h mplayer/gtk/opts.h mplayer/widgets.h skin/skin.h wm/ws.h wm/wskeys.h wm/wsxdnd.h

Uoti Urpala uoti.urpala at pp1.inet.fi
Mon Jul 2 22:59:34 CEST 2007

On Mon, 2007-07-02 at 22:36 +0200, diego wrote:
> Consistently use filenames as multiple inclusion guards.

I don't like this commit even though it probably doesn't break anything
worse than it already is. All the new "consistent" names are still
reserved C names which should not be used as #defines. And using the
file name alone might not always be enough, there could be similarly
named headers in multiple directories.

I see you just changed some of the headers again in another commit
adding a GUI prefix, but still but still using reserved names and in
some cases one underscore, in others two.

More information about the MPlayer-cvslog mailing list