[MPlayer-cvslog] r23703 - in trunk/gui: app.h mplayer/gmplayer.h mplayer/gtk/mb.h mplayer/gtk/opts.h mplayer/widgets.h skin/skin.h wm/ws.h wm/wskeys.h wm/wsxdnd.h

Attila Kinali attila at kinali.ch
Tue Jul 3 18:17:27 CEST 2007

On Tue, 03 Jul 2007 17:42:15 +0300
Uoti Urpala <uoti.urpala at pp1.inet.fi> wrote:

> What do you mean by "splitting"? Didn't you change all of those lines
> again, thus not making the later commits any smaller? To me it looks
> like you made a big commit even bigger by committing completely useless
> partially-fixed versions AND then the fixed version.

I have to agree with Uoti on this. 5 commits is a little bit too
much for the same thing. One would have been enough, two (one to
fix the underscores and one to make consitent names) would be
also ok, but 5 is a little bit overkill.

			Attila Kinali

Praised are the Fountains of Shelieth, the silver harp of the waters,
But blest in my name forever this stream that stanched my thirst!
                         -- Deed of Morred

More information about the MPlayer-cvslog mailing list