[MPlayer-cvslog] r23703 - in trunk/gui: app.h mplayer/gmplayer.h mplayer/gtk/mb.h mplayer/gtk/opts.h mplayer/widgets.h skin/skin.h wm/ws.h wm/wskeys.h wm/wsxdnd.h

Uoti Urpala uoti.urpala at pp1.inet.fi
Wed Jul 4 17:57:46 CEST 2007

On Wed, 2007-07-04 at 12:11 +0200, Diego Biurrun wrote:
> On Tue, Jul 03, 2007 at 05:42:15PM +0300, Uoti Urpala wrote:
> > What do you mean by "splitting"? Didn't you change all of those lines
> > again, thus not making the later commits any smaller? To me it looks
> > like you made a big commit even bigger by committing completely useless
> > partially-fixed versions AND then the fixed version.
> Just removing the underscores made the GUI not compile anymore (some
> multiple inclusion guards were duplicated), so I had to change those
> first in order to be able to have one commit just remove the
> underscores.  Some other inconsistencies I noticed in between and
> committed them in batches as I found them.

Was there any benefit compared to picking a consistent naming scheme and
then changing everything to use that at once (or divided in parts by
header, but not changing any one header more than once)?

> Sure, I could have tried to do it all in one big change, but I like to
> err on the side of too many, not too few commits and the other devs
> mostly agree.

You split changes in single #define names. I don't think any developer
is so dumb that they'd benefit from changing the names a few characters
at a time to explain what is going on.

More information about the MPlayer-cvslog mailing list