[MPlayer-cvslog] r23446 - in trunk/loader: Makefile driver.cregistry.c win32.c

[Reimar Doeffinger]

Hello,
On Thu, Jul 05, 2007 at 11:45:06AM +0200, Carl Eugen Hoyos wrote:
> On 2007-06-02 12:24, diego wrote:
> > Author: diego
> > Date: Sat Jun  2 14:24:35 2007
> > New Revision: 23446
> > 
> > Log:
> > Get rid of superfluous MPLAYER #define, it was always enabled and
> > cluttered the code. Blessed by Reimar.
> 
> This broke modify_reg.c, a file from the CoreAVC patch.
> http://article.gmane.org/gmane.comp.video.mplayer.devel/41186
> 
> Since I want to work on this patch: Would it be ok to revert?

It may be too much effort, but I'd prefer "reimplementing" it over
reverting, doing things like
1) calling it e.g. "STANDALONE" instead of "MPLAYER" (and inverting the
logic, so the default build system doesn't have to define it)
2) Possibly using it in less places
3) Maybe implementing a mpstub.c that could be just to provide
everything needed so the same object files as for MPlayer can be used,
possibly also useful for codec-cfg.c

Greetings,
Reimar Doeffinger