[MPlayer-cvslog] r23793 - trunk/mpcommon.mak

[Diego Biurrun]

On Tue, Jul 17, 2007 at 08:14:21AM +0300, Uoti Urpala wrote:
> On Mon, 2007-07-16 at 22:13 +0200, diego wrote:
> > Log:
> > Reorder CFLAGS, fixes compilation after addition of png.h to FFmpeg.
> 
> > -CFLAGS += $(CFLAGS-yes) $(OPTFLAGS)
> > +CFLAGS += $(OPTFLAGS) $(CFLAGS-yes) 
> 
> Doesn't work for two reasons.
> png.h is normally from /usr/include, which is not guaranteed to be
> explicitly listed in OPTFLAGS (and IMO should not be).
> Even if there is an -I/usr/include, it has no effect with current gcc:
> 
>       -I dir
>            Add the directory dir to the list of directories to be searched for
>            header files.  Directories named by -I are searched before the
>            standard system include directories.  If the directory dir is a
>            standard system include directory, the option is ignored to ensure
>            that the default search order for system directories and the spe‐
>            cial treatment of system headers are not defeated.
> 
> As that explains the position of -I/usr/include doesn't matter as such
> an option is completely ignored to avoid breaking system headers.

Yes, you are right, thanks for explaining in detail.  I've put a bandaid
fix in place, at least the tree should compile for everybody again.

Diego