[MPlayer-cvslog] r23925 - in trunk: configure etc/codecs.conf libao2/ao_v4l2.c libao2/audio_out.c libvo/video_out.c libvo/vo_v4l2.c

[Reimar Döffinger]

Hello,
On Sun, Jul 29, 2007 at 11:07:21PM +0200, Benjamin Zores wrote:
> Reimar Döffinger a écrit :
> > Hello,
> > On Sun, Jul 29, 2007 at 09:20:55PM +0200, ben wrote:
> >> Author: ben
> >> Date: Sun Jul 29 21:20:55 2007
> >> New Revision: 23925
> >>
> >> Log:
> >> v4l2 audio/video outputs for linux 2.6.22+ kernels (outputs formerly known as ivtv)
> > 
> > Could you please explain what the point is in that massive code
> > duplication?
> 
> I wouldn't say "massive" but the point is:

Two files, one a practically identical and the other only with one
single function removed. But I don't mind saying "pointless" instead of
"massive" if you prefer.

> - vo_ivtv is specific to IVTV cards
> - vo_v4l2 is generic to all V4L2 MPEG cards (and IVTV is one of them 
> starting from 2.6.22) so it's definitely the way to go anyhow.
> 
> I'd like to avoid having a v4l2 "generic" vo that is full if #ifdef 
> kernel_version >= xyz and #ifdef with ioctl from a proprietary API.

It would be one single #ifdef. But actually since the IOCTL numbers
probably don't change you would only have to define these if they are
not already.
And in case that ioctl actually causes problems with the "generic" stuff
you could add a suboption that en- or disables it.
I really don't see the point in doing it like this so far at all.
Especially the ao was a purely cosmetic change.

Greetings,
Reimar Döffinger