[MPlayer-cvslog] r22314 - trunk/TOOLS/vfw2menc.c

[Reimar Döffinger]

Hello,
On Tue, Mar 06, 2007 at 07:47:34AM -0500, Compn wrote:
> On Tue, 06 Mar 2007 12:29:00 +0100, 
> Reimar Döffinger scribed:
> > On Fri, Feb 23, 2007 at 03:25:59PM -0500, Compn wrote:
> > > On Thu, 22 Feb 2007 20:25:09 +0100, 
> > > Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> scribed:
> > > > On Thu, Feb 22, 2007 at 08:03:36PM +0100, compn wrote:
> > > > [...]
> > > > > +#define __VERSION__ "0.1"
> > > > > +
> > > > 
> > > > Recent discussions said that defines starting with __ are reserved
> > > > and might cause compilation to fail, so could this please be
> > > > avoided?
> > > 
> > > i've asked gianluigi if he could maintain this.
> > > 
> > > if no one responds, i'll change this. it still compiles for me
> > > and the TOOLS dir is not part of the makefile...
> > > 
> > > i'm still trying to find someone to build this with/without getopt.c
> > > on linux to see if that file is needed.
> > 
> > Any news?
> > 
> 
> what should __VERSION__ be changed to ? just vf2menc_version ?
> i'm lacking programming skills...

Well, just VERSION would probably be okay, but I don't know why it had
the underscores in the first place, maybe there is a reason (e.g.
because of MSVC?).

Greetings,
Reimar Döffinger