[MPlayer-cvslog] r23255 - trunk/libmenu/menu.c

[Reimar Döffinger]

Hello,
On Mon, May 07, 2007 at 10:35:39PM +0200, Benjamin Zores wrote:
> Reimar Döffinger a écrit :
> > On Mon, May 07, 2007 at 09:48:15PM +0200, ben wrote:
> >> Author: ben
> >> Date: Mon May  7 21:48:15 2007
> >> New Revision: 23255
> >>
> >> Log:
> >> cast to what's really expected
> >>
> >> Modified:
> >>    trunk/libmenu/menu.c
> >>
> >> Modified: trunk/libmenu/menu.c
> >> ==============================================================================
> >> --- trunk/libmenu/menu.c	(original)
> >> +++ trunk/libmenu/menu.c	Mon May  7 21:48:15 2007
> >> @@ -306,7 +306,7 @@ static int get_next_char(char **txt)
> >>    c = (unsigned char)*(*txt)++;
> >>    if (c >= 0x80) {
> >>      if (menu_utf8)
> >> -      c = utf8_get_char((const char*)txt);
> >> +      c = utf8_get_char((const char**)txt);
> > 
> > Why do you have that cast anyway? Seems really pointless to me.
> 
> utf8_get_char requires a const, it just kills a warning.

And why on hell is that stupid compiler warning about it? Unless someone
comes up with a good reason for the warning I'd be strongly in favour of
ignoring the warning.
These casts only create a mess, esp. considering that I think the
get_next_char argument preferably would be const, too.
Actually I would have thought all text arguments should be const, but it
seems that menu_fribidi through fribidi_charset_to_unicode might
actually modify it?

Greetings,
Reimar Döffinger