[MPlayer-cvslog] r24918 - in trunk: libaf/af.c libaf/af_tools.c libaf/filter.c libaf/format.c libvo/x11_common.c

[Reimar Döffinger]

Hello,
On Thu, Nov 01, 2007 at 05:20:34AM -0400, Rich Felker wrote:
> On Thu, Nov 01, 2007 at 07:52:10AM +0100, uau wrote:
> > Author: uau
> > Date: Thu Nov  1 07:52:10 2007
> > New Revision: 24918
> > 
> > Log:
> > Remove some pointless 'inline' qualifiers
> > 
> > Most of these functions aren't even used in the same translation unit.
> > 
> > 
> > Modified:
> >    trunk/libaf/af.c
> >    trunk/libaf/af_tools.c
> >    trunk/libaf/filter.c
> >    trunk/libaf/format.c
> >    trunk/libvo/x11_common.c
> > 
> > Modified: trunk/libaf/af.c
> > ==============================================================================
> > --- trunk/libaf/af.c	(original)
> > +++ trunk/libaf/af.c	Thu Nov  1 07:52:10 2007
> > @@ -572,7 +572,7 @@ double af_calc_delay(af_stream_t* s)
> >  
> >  /* Helper function called by the macro with the same name this
> >     function should not be called directly */
> > -inline int af_resize_local_buffer(af_instance_t* af, af_data_t* data)
> > +int af_resize_local_buffer(af_instance_t* af, af_data_t* data)
> 
> Is non-static inline even valid C? I doubt it... This looks like C++
> code masquerading as C......

No, it isn't and causes problems with Sun C compiler (though we have a
lot of issues with that anyway).

Greetings,
Reimar Döffinger