[MPlayer-cvslog] r24911 - trunk/libmpcodecs/dec_audio.c

[Reimar Döffinger]

Hello,
On Fri, Nov 02, 2007 at 09:09:13AM +0200, Uoti Urpala wrote:
> On Thu, 2007-11-01 at 11:02 +0100, Reimar Döffinger wrote:
> > > Log:
> > > Reindent dec_audio.c
> > > 
> > > Also remove some commented out code
> > 
> > Nice work on the audio stuff, but I really wished you had split this one
> > more, e.g. the whitespace-only stuff separately so it could be easily
> > verified with "svn diff --diff-cmd diff -x '-duwbB'".
> > It's feasible even like this but quite an effort :-(
> 
> I'm not sure what kind of splitting you mean. I don't see any way to
> split the changes in a way that would make checking them significantly
> easier. Diff still could not filter out whitespace changes that involve
> newlines, and on the other hand other whitespace changes are equally
> easy to filter out whether they're in a separate commit or not.

Well, at least not for my eyes.

e.g.

> - if (lots of stuff)
> - {
> + if (lots of stuff) {

vs.

> - if (lots of stuff)
> - {
> +        if (lots of stuff) {

At least -duwbB does not make it adjust differing lines to minimize
whitespace differences (does and option exist that does that? I found
none).

> If you want to see changes other than pure formatting, try this:
> git show <commit>:libmpcodecs/dec_audio.c >v2.c
> git show <commit>^:libmpcodecs/dec_audio.c >v1.c
> indent -kr -l999 -fca -fc1 v1.c v2.c
> diff -u v1.c v2.c

Yes, it's not a big deal. Though I personally don't trust indent, a few
years ago it managed to break a file using macros...

Greetings,
Reimar Döffinger