[MPlayer-cvslog] r24941 - trunk/mplayer.c

[Reimar Döffinger]

Hello,
On Sun, Nov 04, 2007 at 05:37:59PM +0200, Uoti Urpala wrote:
> On Sun, 2007-11-04 at 10:13 +0100, Nico Sabbi wrote:
> > You are the only one that doesn't make the slighest effort to
> > prevent breaking gcc 2.95, even when it would cost nothing 
> 
> It would cost in code quality. For example in this case the variable
> declaration is irrelevant clutter at the start of the function, while
> the type of the variable is obscured in the part of code where it is
> used. I'm also not willing to make a habit of writing inferior code.

I'd happily agree with that if _every_ use (or at least assignment) of
the variable had the type (though it would bloat the code, so not
_really_ good either), but like this only the first use of the
variable has the type, and if I stumble over the later uses it becomes
much harder to find out the type, because I can't just simply look at
the start of blocks (yes, I can use the search function, but that is
additional effort and works badly with some names).
You believe that using declarations this way results in better code. It
seems the rest of use don't though. And that makes me really certain
that it is not as clearly an advantage as you seem to believe.

Greetings,
Reimar Döffinger