[MPlayer-cvslog] r24977 - trunk/libvo/vo_directfb2.c

[Diego Biurrun]

On Wed, Nov 07, 2007 at 02:21:24AM +0200, Ivan Kalvachev wrote:
> 2007/11/6, diego <subversion at mplayerhq.hu>:
> >
> > Log:
> > Reduce excessive verbosity: Move debug messages to the appropriate MSGL
> > and comment out the silliest ones.
> >
> > --- trunk/libvo/vo_directfb2.c  (original)
> > +++ trunk/libvo/vo_directfb2.c  Tue Nov  6 10:41:38 2007
> > @@ -183,7 +183,7 @@ static int preinit(const char *arg)
> >        {NULL}
> >      };
> >
> > -    mp_msg(MSGT_VO, MSGL_INFO,"DirectFB: Preinit entered\n");
> > +    //mp_msg(MSGT_VO, MSGL_INFO,"DirectFB: Preinit entered\n");
> 
> I don't mind changing the verbosity level to DBG4, as these messages
> are not useful in another situation.
> 
> But I object of removing debug messages entirely, by commenting them out.
> They may look silly to you, but I have the same silly messages in xvmc
> and I have them for good reason - They were needed for debugging.

And once somebody sits down to debug that piece of code again, they are
trivial to reenable.  Read the file, almost all functions have debug
statements along the lines of "function entered" and "function left" in
them.  Most are commented out, some are left in there.  Now all are
commented out consistently.

Debugging does not in any way harder by removing // so I see no need to
reenable those messages.

Diego