[MPlayer-cvslog] r24941 - trunk/mplayer.c

[Diego Biurrun]

On Fri, Nov 09, 2007 at 12:21:53PM +0200, Uoti Urpala wrote:
> On Wed, 2007-11-07 at 15:32 -0500, Compn wrote:
> > can you give us a link or outline your 'good development policy' for us?
> > maybe there is something mplayer/ffmpeg team can add/remove from its
> > policy. 
> 
> Here are some things that I think could be improved in svn-howto.txt
> which is probably the closest to policy (though I wouldn't classify all
> these things as "policy"):
> - The svn cp hack for reverting doesn't belong in Subversion basics. IMO
> much of the other text in the "Reverting broken commits" part is
> questionable too. However in practice this comes up seldom enough that
> improving the text isn't too important.

I agree, this does not belong in Subversion basics.

> - There are parts implying strict code ownership by maintainers and even
> an explicit warning against against committing "trivial looking
> fixes" (wtf?). Those should be replaced by something more flexible.

This is historic.  I think Arpi added it after I made some silly
mistake, but I don't remember all the details.

> - The parts that are strongly worded against any indentation changes
> such as "If you really need to make indentation changes (try to avoid
> this)" and the requirement to even intentionally leave incorrect
> indentation in the file if the reindent required would be > 5 lines
> should be removed. The first priority should be the quality of the
> resulting code.

I agree this could or even should be reworded.  However, our policy
nowadays is to clean up indentation immediately afterwards.  The text
does not convey this, yes.

> - The instructions on how to write commit messages could be better.

Yes, I agree totally, commit messages could be vastly improved in
general.  Unfortunately commit messages are not appreciated enough as
the source of documentation they represent.

Diego