[MPlayer-cvslog] r25029 - trunk/libmpdemux/demux_nemesi.c

[Michael Niedermayer]

On Tue, Nov 13, 2007 at 10:58:31AM +0100, Diego Biurrun wrote:
> On Tue, Nov 13, 2007 at 03:46:57AM +0100, Michael Niedermayer wrote:
> > On Mon, Nov 12, 2007 at 11:27:25PM +0100, Diego Biurrun wrote:
> > > On Mon, Nov 12, 2007 at 05:56:23PM +0100, lu_zero wrote:
> > > > 
> > > > Log:
> > > > support extradata for audio streams
> > > > 
> > > > --- trunk/libmpdemux/demux_nemesi.c	(original)
> > > > +++ trunk/libmpdemux/demux_nemesi.c	Mon Nov 12 17:56:23 2007
> > > > @@ -74,7 +74,7 @@ static void link_session_and_fetch_conf(
> > > >      rtp_buff trash_buff;
> > > > -    int must_prefecth = ((fps != NULL) || (buff != NULL)) ? 1 : 0;
> > > > +    int must_prefetch = ((fps != NULL) || (buff != NULL)) ? 1 : 0;
> > > 
> > > Unrelated typo fix.
> > 
> > yes, luca please revert this commit, and recommit it in correctly split
> > form!
> 
> I don't think this would help any.  But surely if Luca's name was Uoti

well if roots oppinion is that luca doesnt have to follow policy or
common sense and instead only uoti has to follow it or maybe that noone
has to care about spliting changes properly then well so be it i cant
do anything. but it definitly is not my oppinion that random unrelated
changes especially not cosmetic and non cosmetic can be commited together

and what it helps, well readability of svn log, blame, diff, ...
besides that reverting, spliting and recommiting costs time and leads to
"if i dont split it cleanly i will have to clean it up later anyway which
is more work" -> higher code quality
vs.
"if i dont split it cleanly thouse in power will just ok it and this is
a small change so why bother"

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20071113/c2a01633/attachment.pgp>