[MPlayer-cvslog] r25061 - trunk/libmpdemux/demux_mf.c

[Rich Felker]

On Sun, Nov 18, 2007 at 11:11:46AM +0100, Reimar Döffinger wrote:
> > Also, const char type[5]; would probably be saner than const char
> > *type.. If nothing else it will be smaller on 64bit and no worse on
> > 32bit.
> 
> It saves 19 bytes on 64 bit at the expense of not working right with
> long extensions or type names (no idea if we'll actually ever need it
> though).
> Feel free to apply e.g. attached patch if you think it is really better.

I'm indifferent, but this is a good issue to be aware of at least,
especially when coding libraries. Tables with pointers in them like
this are not really const in a shared library and must reside in data
(and use up dirty pages) even if they're never used by the program.
But since libmpdemux is internal only and never intended for use as a
shared library it doesn't matter so much.

Rich