[MPlayer-cvslog] r25065 - trunk/stream/stream_dvd.c

[Reimar Döffinger]

Hello,
On Sun, Nov 18, 2007 at 10:07:01PM +0100, Ivo wrote:
> On Sunday 18 November 2007 20:39, Reimar Döffinger wrote:
> > On Sun, Nov 18, 2007 at 08:06:05PM +0100, Ivo wrote:
> > [...]
> >
> > > I think checking for byteswap.h in configure and setting
> > > HAVE_BYTESWAP_H accordingly should suffice, shouldn't it?
> >
> > Still a mess either way.
> > Try just moving the intreadwrite.h include directly below config.h
> > If it works and if you have time, try moving it down until it breaks
> > again so we know who includes byteswap.h.
> 
> The offending include is:
> 
> #include <linux/cdrom.h>
> 
> If I place intreadwrite.h before it, it compiles ok. After it, it fails.

Feel free to place it somewhere before, but that header really has no
business defining bswap stuff: IOW, I'd say yet another case of broken
system headers.
On all my systems (Gentoo, Debian testing, OpenSuSE 10.3, Fedora 8), that
header only includes <asm/byteorder.h> and that one has the sense of only
defining ___arch__swab32 etc.

Greetings,
Reimar Döffinger