[MPlayer-cvslog] r25135 - trunk/libmpdemux/muxer_lavf.c

[Ivan Kalvachev]

2007/11/22, Jindrich Makovicka <makovick at gmail.com>:
> On Thu, 22 Nov 2007 15:59:45 +0200
> "Ivan Kalvachev" <ikalvachev at gmail.com> wrote:
>
> > 2007/11/22, iive <subversion at mplayerhq.hu>:
> > > Author: iive
> > > Date: Thu Nov 22 01:22:29 2007
> > > New Revision: 25135
> > >
> > > Log:
> > > Fix compilation error.
> > > FFmpeg commit r11071 removed the static ByteIOContext from
> > > AVFormatContext and replaced it with dynamic. However muxer_lavf.c
> > > haven't been modified to reflect that change.
> >
> > This commit fixes compilation, but the muxer is still broken. I'll
> > probably send patch for this in the lavf demuxer thread as changes are
> > similar.
>
> I think the following bit is still missing:
>
> --- libmpdemux/muxer_lavf.c     (revision 25139)
> +++ libmpdemux/muxer_lavf.c     (working copy)
> @@ -317,7 +317,7 @@
>                 av_freep(&(priv->oc->streams[i]));
>         }
>
> -       url_fclose(&(priv->oc->pb));
> +       url_fclose(priv->oc->pb);
>
>         av_free(priv->oc);
>  }

Yes, I already send patch to mplayer-dev containing that change. It
also makes changes to *pb in muxer_priv_t , that is probably not
necessary as it is not used anywhere. (Still static ByteIOContext
can't be used anymore).

The field "AVFormatContext oc" seems to be the only one that is used
in the muxer_priv_t, the others (pb,audio/video_streams, last_pos) are
not used...
I wonder if they are legacy cruft or are kept for future extension.