[MPlayer-cvslog] r24362 - in trunk: mpcommon.c stream/tv.h stream/tvi_vbi.c

[Reimar Döffinger]

Hello,
On Sat, Sep 08, 2007 at 05:06:23AM +0200, voroshil wrote:
[...]
> +    case TV_VBI_CONTROL_IS_CHANGED:
> +        if((GetTimerMS()/250)%2)  //forcing page update every 1/4 sec
> +            priv->page_changed=3; //mark that header update is enough

I don't think this is such a good way of doing this.
First, this forces an update every 500, not 250 ms.
Second, if for some reason TV_VBI_CONTROL_IS_CHANGED is called rarely
and at the wrong times, this might never trigger at all.
The later problem could probably be fixed by storing the timestamp of the last
update and checking the delta.

Greetings,
Reimar Döffinger