[MPlayer-cvslog] r24535 - trunk/osdep/getch2.c

[Ivan Kalvachev]

Thank you for taking the little credit I had about this patch.

Next time don't forget to reply to the thread in mplayer-dev, when you
commit the code in question.


2007/9/15, uau <subversion at mplayerhq.hu>:
> Author: uau
> Date: Sat Sep 15 20:13:56 2007
> New Revision: 24535
>
> Log:
> getch2: Fix incorrect test
>
> Keycode length wasn't checked in one case because of missing
> parentheses. This was accidentally broken in my previous commit to the
> file. Most likely the error had no practical effect; the length checks
> are unreliable in any case as they can be satisfied by unrelated
> data corresponding to other keypresses.
>
>
> Modified:
>    trunk/osdep/getch2.c
>
> Modified: trunk/osdep/getch2.c
> ==============================================================================
> --- trunk/osdep/getch2.c        (original)
> +++ trunk/osdep/getch2.c        Sat Sep 15 20:13:56 2007
> @@ -200,7 +200,7 @@ void getch2(void)
>                      goto found;
>                  }
>              }
> -            if (c == '[' || c == 'O' && getch2_len >= 3) {
> +            if ((c == '[' || c == 'O') && getch2_len >= 3) {
>                  int c = getch2_buf[2];
>                  const short ctable[] = {
>                      KEY_UP, KEY_DOWN, KEY_RIGHT, KEY_LEFT, 0,
> _______________________________________________
> MPlayer-cvslog mailing list
> MPlayer-cvslog at mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/mplayer-cvslog
>