[MPlayer-cvslog] r26411 - trunk/libmpdemux/demuxer.c

[Diego Biurrun]

On Sat, Apr 12, 2008 at 06:23:08PM +0200, Reimar Döffinger wrote:
> On Sat, Apr 12, 2008 at 05:51:08PM +0200, uau wrote:
> > 
> > Log:
> > Reindent demuxer.c
> 
> This is not only a reindentation, this also does other cosmetic changes,
> which makes this simply unreviewable,

I had no trouble reviewing the output of

svn diff -r 26410:26411 --diff-cmd diff -x -uwbBE

But of course, Subversion is not configured to output this form of diff.
I have attached it for your convenience.

> and also you are supposed to ask about cosmetic changes before for code
> you don't maintain.
> I have simply had enough, if this is the only way you can behave, I
> simply can't and don't want to work with you, no matter how good your
> code may be.
> I'll maintain my code as long as that is desired, but I simply don't
> want to actively work in this environment anymore.

Reimar, you are overreacting.

That said, I'm not happy about the log message.  It should clearly state
that you also remove commented-out code and useless parentheses.

Diego