[MPlayer-cvslog] r26411 - trunk/libmpdemux/demuxer.c

[Compn]

On Sat, 12 Apr 2008 19:51:26 +0300, Uoti Urpala wrote:
>On Sat, 2008-04-12 at 18:23 +0200, Reimar Döffinger wrote:
>> > Log:
>> > Reindent demuxer.c
>> 
>> This is not only a reindentation, this also does other cosmetic
>> changes, which makes this simply unreviewable, and also you are
>> supposed to ask
>
>By "unreviewable" do you mean double-checking that it doesn't

unreviewable means the diff generated by svn was not human readable.
aka it wasnt easy to see what was just a reindent and what else was
changed.

>> about cosmetic changes before for code you don't maintain.
>> I have simply had enough, if this is the only way you can behave, I
>> simply can't and don't want to work with you, no matter how good your
>> code may be.
>> I'll maintain my code as long as that is desired, but I simply don't
>> want to actively work in this environment anymore.
>
>Does this cause some actual problems for your work? If so, what? If you
>had some patches with conflicts then I'm willing to help resolve those.

can we get you to submit patches next time for stuff like this ?
or even without patches just like 'i am planning to reindent demuxer.c,
are there any objections or comments' 

this doesnt help the mplayer code, or speed it up, but it does help the
remaining mplayer developers keep track of the codebase. if they cant
keep track of changes , they will agree to kick out anyone who is
implementing changes without review. and i would hate to see that
happen to any developer.