[MPlayer-cvslog] r27407 - in trunk: Changelog DOCS/man/en/mplayer.1 DOCS/man/fr/mplayer.1 DOCS/tech/MAINTAINERS configure libvo/video_out.c libvo/vo_wii.c

[Ivan Kalvachev]

On 8/3/08, ben <subversion at mplayerhq.hu> wrote:
> Author: ben
> Date: Sun Aug  3 22:04:03 2008
> New Revision: 27407
>
> Log:
> Add video driver for Nintendo Wii/GameCube.
>
> Original patch by Jing Liu <fatersh-1 at yahoo.com>,
> based on vo_fbdev.c and adapted to Nintendo's specific GPU.
>
> This driver handles dedicated ATI GPU, which can be found in:
>  - Nintendo GameCube (ATI LSI Flipper @ 162 MHz)
>  - Nintendo Wii (ATI Hollywood @ 243 MHz)
>
> Flipper and Hollywood chipsets are pretty similar, except from clock speed:
>  - Embedded framebuffer is 2MB.
>  - Texture cache is 1MB.
>  - Vertex cache is 0.1 MB.
>  - Framebuffer is YUY2, not RGB.
>  - Best resolution is 480p (854x480)

It is not simply based, it is 90% the vo_fbdev.c code.
This means the copyright note in the file is not correct.
The very same commit message say this person have written
patch not the entire file.

At the moment there isn't any kind of attribution to
the original source/authors other
than the commit message.

At least, such stuff should be committed after svn cp.

The Wii specific code is so minor that I fail to find it,
It is much more preferable if the needed improvements
(e.g. maybe YUY2 detection by fb_info.nostd)
are incorporated into the fbdev instead of such massive
code duplication.


I don't see patch for that in -dev-eng.
It is not mandatory but is gesture towards other developer(s)
and helps such kind of problems to be spotted and fixed
before commit.