[MPlayer-cvslog] r23727 - trunk/libdvdcss/libdvdcss.c

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Aug 30 19:24:41 CEST 2008

On Thu, Aug 21, 2008 at 10:41:53PM +0200, Diego Biurrun wrote:
> > AFAICT sprintf behaviour is unspecified when the types mismatch as is
> > the case without this patch.
> > But actually this is moot, since AFAICT sprintf isn't really specified
> > sufficiently to be used in this way if you are pedantic. Which is why I
> > proposed a different patch on libdvdcss-devel
> Your patch does not even compile:

Nor does it work, one of the to_hex calls should be using psz_tmp.
This was just a quick copy-and-paste hack to get some comments.
I mainly do not like the current code because it assumes sprintf
will have a certain output - but its behaviour can completely
change simply because a different locale is set) even though
it is very unlikely in case of %x.

Reimar Döffinger

More information about the MPlayer-cvslog mailing list