[MPlayer-cvslog] r25951 - in trunk: cfg-mplayer.h libmpdemux/demux_lavf.c libmpdemux/demux_mkv.c libmpdemux/demux_real.c libmpdemux/demuxer.c libmpdemux/demuxer.h

[Uoti Urpala]

On Mon, 2008-02-04 at 09:45 +0100, Reimar Döffinger wrote:
> On Sun, Feb 03, 2008 at 10:45:56PM +0200, Uoti Urpala wrote:
> > I don't like this and the similar changes in other demuxers. It assumes
> > that the logic setting the real correct_pts works in a particular way
> > based on user_correct_pts and will break if that changes (and it could
> > well change).
> 
> I agree, I just did not yet think of something better.

I think it would have been better to select the value of correct_pts
before calling demuxer open. It wouldn't be a general API for all
possible cases, but IMO your version does not work for that either, and
it would at least keep the logic in one place.

> > Was there any need for this particular change? Can this code somehow be
> > executed before correct_pts has its final value?
> 
> Yes, demux_open calls ds_fill_buffer.

Then you broke the other places which can return "pts=unknown". They do
that by leaving the default value set by new_demux_packet in the field,
and new_demux_packet sets that depending on correct_pts.