[MPlayer-cvslog] r25811 - trunk/mencoder.c

[Reimar Döffinger]

Hello,
On Tue, Feb 12, 2008 at 09:05:39PM -0500, Rich Felker wrote:
> On Wed, Feb 13, 2008 at 12:56:15AM +0200, Ivan Kalvachev wrote:
> > On Feb 12, 2008 6:22 PM, Reimar Döffinger
> > <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > > On Mon, Feb 11, 2008 at 01:18:22PM -0500, Rich Felker wrote:
> > > > On Sun, Jan 20, 2008 at 12:19:42AM +0100, iive wrote:
> > > > > Author: iive
> > > > > Date: Sun Jan 20 00:19:41 2008
> > > > > New Revision: 25811
> > > > >
> > > > > Log:
> > > > > Extend the precision of rationale conversion so
> > > > > it would give proper result for framerate 60000/1001 .
> > > > > Otherwise framerate restrained encoders like lavc mpeg2video
> > > > > would refuse to encode, even if -ofps 60000/1001 is given.
> > > >
> > > > This commit seems to have seriously broken MEncoder. See the thread on
> > > > -users..
> > >
> > > Mostly it should be changed to use double, but how about
> > > av_d2q(fps, fps*1001+1);
> > > or so as a quick hack?
> > 
> > I wish I had come with that idea. Make it +2 and commit.
> 
> Feel free to do this, but also it'd be nice to check first how
> difficult it would be to change the framerate to a double..

I did this change and I also changed fps to double in several places
(though at least sh_video and probably a few others are missing).

Greetings,
Reimar Döffinger