[MPlayer-cvslog] r26039 - in trunk: gui/cfg.h libao2/audio_out.c libmenu/menu.c libvo/sub.h libvo/video_out.c libvo/x11_common.h mencoder.c mpcommon.h mplayer.c osdep/getch2.h stream/stream.c subreader.h

[Rich Felker]

On Wed, Feb 20, 2008 at 08:17:37PM +0100, Alban Bedel wrote:
> On Wed, 20 Feb 2008 17:10:18 +0100
> Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> 
> > Hello,
> > On Wed, Feb 20, 2008 at 09:51:53AM +0100, diego wrote:
> > > Modified: trunk/mpcommon.h
> > > ==============================================================================
> > > --- trunk/mpcommon.h	(original)
> > > +++ trunk/mpcommon.h	Wed Feb 20 09:51:53 2008
> > > @@ -2,9 +2,7 @@
> > >  #define MPCOMMON_H
> > >  
> > >  extern double sub_last_pts;
> > > -#ifdef USE_ASS
> > >  extern ass_track_t *ass_track;
> > > -#endif
> > 
> > That does not work like this currently, because without USE_ASS the
> > ass_track_t type is not defined.
> > You either need to add that ifdef back or make sure ass_track_t is
> > always defined here (former is probably better).
> 
> Or use struct foo*, as it is a pointer you don't need the full
> definition.

Indeed, this is one reason I hate the overuse of typedefs for
structs..

Rich