[MPlayer-cvslog] r26069 - in trunk/libmpdemux: demuxer.c demuxer.h

[Nico Sabbi]

Il Saturday 23 February 2008 21:13:07 Uoti Urpala ha scritto:

> 
> Using demuxers for timing is a bad idea, and IMO blocking in them should
> be avoided when possible. Your patch certainly doesn't implement any
> mechanism that would properly sync MPlayer playback with the source
> speed.
> 
> > I see a lot of improvements with it
> 
> Maybe blocking at another moment happens to give smoother playback in
> some situation, but that does not make your patch correct. If MPlayer's
> playback was too slow before and buffers filled up your patch can only
> make it worse. If playback stuttered because of empty buffers then
> either MPlayer didn't buffer enough data before starting playback or
> playback speed was too high. Your patch doesn't have anything which
> could really fix either cause. Something similar could be used to
> determine the amount to buffer when starting playback, but your current
> code is not a proper implementation of that either.
> 

why didn't you complain sooner? I posted the patch 2 days ago