[MPlayer-cvslog] r25777 - in trunk/libswscale: rgb2rgb_template.c swscale-example.c swscale.c swscale_altivec_template.c swscale_template.c yuv2rgb_altivec.c

Benoit Fouet benoit.fouet at purplelabs.com
Thu Jan 17 11:56:38 CET 2008

Reimar Döffinger wrote:
> Hello,
> On Thu, Jan 17, 2008 at 10:26:34AM +0100, Benoit Fouet wrote:
> [...]
>> I guess that removing parentheses is ok only if it doesn't create new
>> warnings, or ?
> Actually, my and AFAIK a few other's opinion is that the warning should
> be disregarded in the && vs. || case, since the evaluation order is
> obvious to anyone who ever had to do with any kind of logic stuff (or
> IOW it is generally known, accepted and consistent).

there are some of if ((a || b) && (c || d)) in the code, but I won't
change them to a version with less parentheses.
I also saw some if (a != NULL) or if (b == NULL), is it acceptable to
change them to if (a) and if (!b) ?

Purple Labs S.A.

More information about the MPlayer-cvslog mailing list