[MPlayer-cvslog] r25843 - trunk/command.c

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Jan 24 21:56:38 CET 2008

On Thu, Jan 24, 2008 at 08:36:53PM +0100, Guillaume LECERF wrote:
> 2008/1/24, Benjamin Zores <ben at geexbox.org>:
> > Hang on !
> > This was already the case before my patch !
> > That's what happen when the same font is used for OSD and Subs rendering.

Yes, but that patch piled another inconsistency on it to hide it, that is not a
way to keep code sane and maintainable.

> May I suggest this patch I sent :
> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2007-December/055777.html

They're probably ok, though this only seems to confirm that this if/else
stuff is not a way to do it that makes sense...
Well, actually there is a case where it _might_ make sense, namely when
playing multiple files, some with -ass and some without. Though even
then it would be better if the font sizes would always correspond, but
that might be rather hard to do.
Either way, at least the double #ifdefs should go.

Reimar Döffinger

More information about the MPlayer-cvslog mailing list