[MPlayer-cvslog] r25881 - trunk/command.c

[Reimar Döffinger]

Hello,
On Sun, Jan 27, 2008 at 05:02:16PM +0100, Benjamin Zores wrote:
> Reimar Döffinger a écrit :
> > On Sun, Jan 27, 2008 at 04:31:24PM +0100, ben wrote:
> >> Modified:
> >>    trunk/command.c
> >>
> >> Modified: trunk/command.c
> >> ==============================================================================
> >> --- trunk/command.c	(original)
> >> +++ trunk/command.c	Sun Jan 27 16:31:24 2008
> >> @@ -1801,13 +1801,9 @@ static int mp_property_sub_scale(m_optio
> >>                  ass_font_scale = *(float *) arg;
> >>                  ass_force_reload = 1;
> >>              }
> > 
> > Not to annoy you, but is there any reason to keep the
> > if (ass_enabled) ? :-)
> 
> Dunno, any reason to set the values if they won't get used ?

As always. Less code.
The main question is though, how should
mplayer file1 -ass file2 -noass
and
mplayer file1 -noass file2 -ass
behave?
The "right" way to handle this depends mainly on that case...

Greetings,
Reimar Döffinger