[MPlayer-cvslog] r27259 - trunk/libmpcodecs/ad_msadpcm.c

[reimar]

Author: reimar
Date: Fri Jul 11 21:00:49 2008
New Revision: 27259

Log:
Add a comment on shift vs. division


Modified:
   trunk/libmpcodecs/ad_msadpcm.c

Modified: trunk/libmpcodecs/ad_msadpcm.c
==============================================================================
--- trunk/libmpcodecs/ad_msadpcm.c	(original)
+++ trunk/libmpcodecs/ad_msadpcm.c	Fri Jul 11 21:00:49 2008
@@ -171,6 +171,9 @@ static int ms_adpcm_decode_block(unsigne
     upper_nibble ^= 1;
     SE_4BIT(snibble);
 
+    // should this really be a division and not a shift?
+    // coefficients were originally scaled by for, which might have
+    // been an optimization for 8-bit CPUs _if_ a shift is correct
     predictor = (
       ((sample1[current_channel] * coeff1[current_channel]) +
        (sample2[current_channel] * coeff2[current_channel])) / 64) +