[MPlayer-cvslog] r27240 - trunk/configure

[Michael Niedermayer]

On Sat, Jul 12, 2008 at 04:21:34PM +0300, Uoti Urpala wrote:
> On Sat, 2008-07-12 at 15:07 +0200, Michael Niedermayer wrote:
> > On Wed, Jul 09, 2008 at 06:47:04PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > > On Tuesday, 08 July 2008 at 18:11, diego wrote:
> > > > Add -std=gnu99 to gcc CFLAGS if supported. This sets appropriate #defines to
> 
> > > Why the GNU dialect? 
> > 
> > Because uoti wanted it and thouse who where against it have left the project
> > apparently.
> > 
> > 
> > > Shouldn't we aim for ISO C99 instead (-std=c99)?
> > 
> > depends on ones goals.
> 
> Did you fail to understand the reasons I gave in my earlier reply to
> Rathann? Or do you claim those reasons are somehow inadequate?

I rather think that your reasons are awnsering a question noone asked.

Diego added -std=gnu99 to supress some warnings
What warnings? 
Why are they there? 
is the code which produces these warnings correct at all? 
Should the code be changed or the warnings be silenced?
Is -std=gnu99 the only way to silence them?
is it the best way?
Does -std=gnu99 have other effects that might negatively affect mplayer
independant of these warnings?

I fail to see how your smartassed-ness awnseres anything of that


Its hard for me to argue about the appropriateness of -std=gnu99 without
even a hint toward what this commit was trying to fix. Of course its not
hard for you because you dont need to know what the issue was, you already
have decided years ago that -std=gnu99 should be added.

One negative effect -std=gnu99 will likely have is that it will hide
warnings about non-standard gnuisms.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20080713/c6a1322a/attachment.pgp>