[MPlayer-cvslog] r27240 - trunk/configure

[Diego Biurrun]

On Sun, Jul 13, 2008 at 01:58:00AM +0200, Michael Niedermayer wrote:
> On Sat, Jul 12, 2008 at 03:53:35PM +0200, Diego Biurrun wrote:
> > On Sat, Jul 12, 2008 at 03:07:36PM +0200, Michael Niedermayer wrote:
> > > On Wed, Jul 09, 2008 at 06:47:04PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > > > On Tuesday, 08 July 2008 at 18:11, diego wrote:
> > > > > 
> > > > > Log:
> > > > > Add -std=gnu99 to gcc CFLAGS if supported. This sets appropriate #defines to
> > > > > avoid a bunch of implicit declaration warnings in (g)libc headers that define
> > > > > certain functions conditional to those #defines.
> > > > 
> > > > Why the GNU dialect? 
> > > 
> > > Because uoti wanted it and thouse who where against it have left the project
> > > apparently.
> > 
> > Nonsense.  Before this change, we were using -std=gnu89, which is what
> > gcc defaults to.
> 
> Before that we where using the default, now we explicitly ask for the gnu99
> dialect.

I think it is better to be explicit about this.  MPlayer fails to
compile with -std=c99, as does FFmpeg.

> Could you please post a few of the warnings you where trying to fix. There
> may be a more correct and clean way to get rid of them.

Warnings like the following, there was a handful of them:

libmpcodecs/ad_libvorbis.c: In function 'read_vorbis_comment':
libmpcodecs/ad_libvorbis.c:48: warning: implicit declaration of function 'vsscanf'

Diego