[MPlayer-cvslog] r27288 - trunk/configure

Uoti Urpala uoti.urpala at pp1.inet.fi
Tue Jul 15 19:00:02 CEST 2008


On Tue, 2008-07-15 at 18:39 +0200, reimar wrote:
> Author: reimar
> Date: Tue Jul 15 18:39:26 2008
> New Revision: 27288
> 
> Log:
> ALSA stupidly tries to define struct timeval and struct timespec, which
> may cause compilation errors. Check for this and disable ALSA.

Those defines are under
#if !defined(_POSIX_C_SOURCE) && !defined(_POSIX_SOURCE)

With no defines <time.h> does not define struct timeval (the
redefinition happens because ao_alsa.c for some reason includes
<sys/time.h> which defines them unconditionally).

While the ALSA behavior is questionable you're really trying to compile
MPlayer with options/defines that have little chance of working anyway.
And if there was some real problem (a header conflict that appeared in a
realistically usable case) then IMO major functionality like ALSA should
not be silently disabled.

While this commit probably does little practical harm I still dislike
adding unrelated includes like <sys/time.h> to configure tests.




More information about the MPlayer-cvslog mailing list