[MPlayer-cvslog] r27288 - trunk/configure

[Reimar Döffinger]

On Tue, Jul 15, 2008 at 07:42:41PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> On Tuesday, 15 July 2008 at 18:39, reimar wrote:
> > Author: reimar
> > Date: Tue Jul 15 18:39:26 2008
> > New Revision: 27288
> > 
> > Log:
> > ALSA stupidly tries to define struct timeval and struct timespec, which
> > may cause compilation errors. Check for this and disable ALSA.
> 
> The correct way to handle such cases is reporting bugs upstream and maybe
> requiring the version in which they are fixed afterwards. Adding random headers
> that trigger bugs to ALSA tests to make them fail for no apparent reason
> is not ideal. I don't think you should put your anger in the code.

Well, like that it at least compiles even with those headers. Anyway, it
probably is only a problem if _POSIX_C_SOURCE is not defined in which case
MPlayer will not compile anyway.
And "for no apparent reason"? The reason is in configure.log just as
apparent as it is during compilation, with the advantage that most
people will still have a usable MPlayer without having to hack anything.

Greetings,
Reimar Döffinger